Skip to content

fix: remove description validation from inventory and form items#952

Merged
smarcet merged 1 commit into
masterfrom
fix/inventory-form-item-description
May 26, 2026
Merged

fix: remove description validation from inventory and form items#952
smarcet merged 1 commit into
masterfrom
fix/inventory-form-item-description

Conversation

@tomrndom

@tomrndom tomrndom commented May 26, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/86ba3dqdy

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Made description fields optional in sponsor forms by removing required validation constraints
    • Removed required field indicators from description field labels across sponsor-related forms

Review Change Stack

…tems

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 37491ba2-f90a-4e23-b001-ac7a1a0a259b

📥 Commits

Reviewing files that changed from the base of the PR and between cfbeb46 and 8f42d3a.

📒 Files selected for processing (2)
  • src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
  • src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js

📝 Walkthrough

Walkthrough

Two sponsor form components remove required validation from the description field. Both components delete the requiredHTMLValidation() rule from their Formik validation schemas, clean up or reorganize yup imports, and update UI labels to remove the required field asterisk.

Changes

Description field made optional in sponsor forms

Layer / File(s) Summary
Sponsor inventory popup form
src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
Remove requiredHTMLValidation import, delete description validation from schema, and remove * from the description field label.
Sponsor form item form
src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js
Reorganize yup imports, remove description validation from schema, and update the description field label to remove the required indicator.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • fntechgit/summit-admin#775: Main PR removes requiredHTMLValidation() from the description field validation (and required UI indicator) in sponsor-inventory-popup.js and sponsor-form-item-form.js, directly opposing PR #775 which added/changed that same description validation to requiredHTMLValidation() in the corresponding forms.

Suggested reviewers

  • smarcet

Poem

🐰 A description once required, now flows free,
No asterisk marks, no validation decree,
Two forms aligned in their newfound ease,
Optional fields grant flexibility's breeze!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing description validation from inventory and form items components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/inventory-form-item-description

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomrndom tomrndom requested a review from smarcet May 26, 2026 14:26

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 5c79c31 into master May 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants